Hardcode get_tolerance for Float64 for trimming
#648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is definitely a bug somewhere, but without this `@report_opt` or `@report_trim` reports errors here.
oscardssmith
requested changes
Jul 26, 2025
|
Can you give a concrete suggestion? I think hardcoding Float64 and Float32 is reasonable. |
|
what is this number actually used for? Default nonlinear solve tolerance? |
|
Yes. And JET really dislikes it. So, let's do it and then if you have concrete improvements let's follow up, but it's strictly better to just add this for now. |
|
right, but is there a reason we aren't just using |
|
I think @avik-pal had a reason for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is definitely a bug somewhere, but without this
@report_optor@report_trimreports errors here.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.